hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 19984: Beeline should accept -i option to Initializing a SQL file
Date Tue, 15 Apr 2014 13:31:28 GMT


> On April 10, 2014, 11:33 p.m., Xuefu Zhang wrote:
> > beeline/src/main/resources/BeeLine.properties, line 148
> > <https://reviews.apache.org/r/19984/diff/2/?file=552256#file552256line148>
> >
> >     Hive CLI seems honoring init file even for -e option. See CliDriver.java
> >     
> >     From the patch, it seems that init file is executed even with -e option. Could
you verify?
> 
> Navis Ryu wrote:
>     -i <init file> can be used with one of the -e <query> or -f <exec
file>, not both. This is same behavior with CliDriver.

Okay. I see. My mistake. I thought it was talking about -i option. Let's not make this change
as it's unrelated. We can have a separate JIRA to fix the text.


- Xuefu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19984/#review40101
-----------------------------------------------------------


On April 8, 2014, 2:07 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19984/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 2:07 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6561
>     https://issues.apache.org/jira/browse/HIVE-6561
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Hive CLI has -i option. From Hive CLI help:
> {code}
> ...
>  -i <filename>                    Initialization SQL file
> ...
> {code}
> 
> However, Beeline has no such option:
> {code}
> xzhang@xzlt:~/apa/hive3$ ./packaging/target/apache-hive-0.14.0-SNAPSHOT-bin/apache-hive-0.14.0-SNAPSHOT-bin/bin/beeline
-u jdbc:hive2:// -i hive.rc
> ...
> Connected to: Apache Hive (version 0.14.0-SNAPSHOT)
> Driver: Hive JDBC (version 0.14.0-SNAPSHOT)
> Transaction isolation: TRANSACTION_REPEATABLE_READ
> -i (No such file or directory)
> Property "url" is required
> Beeline version 0.14.0-SNAPSHOT by Apache Hive
> ...
> {code}
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 5773109 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 44cabdf 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 493f963 
>   beeline/src/main/resources/BeeLine.properties 697c29a 
> 
> Diff: https://reviews.apache.org/r/19984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message