hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <>
Subject Re: Review Request 20243: HIVE-6891 - Alter rename partition Perm inheritance and general partition/table owner inheritance
Date Sat, 12 Apr 2014 07:59:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 12, 2014, 7:59 a.m.)

Review request for hive.


Fixing a unit test, that used Warehouse.mkdir().

Bugs: HIVE-6891

Repository: hive-git


This is a follow-up of HIVE-6648.

Extending the fix to other partition/table operations as well, by refactoring the fixed code
in HIVE-6648 into a common FileUtils helper method, and then using it for all table/partition
directory creation operation, when "hive.warehouse.subdir.inherit.perms" flag is set.  

Another part of this change is to add ownership inheritance in this code as well when creating
directories.  Ownership was already inherited for data (HIVE-3756), but not at the table/partitioned-table

Diffs (updated)

  common/src/java/org/apache/hadoop/hive/common/ ad82f62 
  itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/ 47e94ea

  metastore/src/java/org/apache/hadoop/hive/metastore/ 8345d70 
  metastore/src/java/org/apache/hadoop/hive/metastore/ c62e085 
  metastore/src/java/org/apache/hadoop/hive/metastore/ f731dab 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/ 2559e0e 



Extending the unit test TestFolderPermission to handle all the new cases of directory creation
(create table, external table, static partition, dynamic partition, rename partition).

Unfortunately due to the test using the local file system, I cannot add the ownership inheritance
to unit-testing.  I can probably look into using MiniDFS for that, in a follow-up JIRA.


Szehon Ho

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message