hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 20243: HIVE-6891 - Alter rename partition Perm inheritance and general partition/table owner inheritance
Date Fri, 11 Apr 2014 00:52:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20243/#review40113
-----------------------------------------------------------


I don't think we will be able to set owner since we are not superuer? But we can set and should
set group.

- Brock Noland


On April 11, 2014, 12:49 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20243/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 12:49 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6891
>     https://issues.apache.org/jira/browse/HIVE-6891
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This is a follow-up of HIVE-6648.
> 
> Extending the fix to other partition/table operations as well, by refactoring the fixed
code in HIVE-6648 into a common FileUtils helper method, and then using it for all table/partition
directory creation operation, when "hive.warehouse.subdir.inherit.perms" flag is set.  
> 
> Another part of this change is to add ownership inheritance in this code as well when
creating directories.  Ownership was already inherited for data (HIVE-3756), but not at the
table/partitioned-table level.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java ad82f62 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java
f1c7b7b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 8345d70 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c62e085 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java f731dab 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2559e0e 
> 
> Diff: https://reviews.apache.org/r/20243/diff/
> 
> 
> Testing
> -------
> 
> Extending the unit test TestFolderPermission to handle all the new cases of directory
creation (create table, external table, static partition, dynamic partition, rename partition).
> 
> Unfortunately due to the test using the local file system, I cannot add the ownership
inheritance to unit-testing.  I can probably look into using MiniDFS for that, in a follow-up
JIRA.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message