hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 16403: HIVE-5176: Wincompat : Changes for allowing various path compatibilities with Windows
Date Wed, 02 Apr 2014 07:22:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16403/#review39243
-----------------------------------------------------------



common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java
<https://reviews.apache.org/r/16403/#comment71604>

    should we just lowercase before comparison, only in windows ?
    
    


- Thejas Nair


On April 2, 2014, 2:11 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16403/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:11 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-5176
>     https://issues.apache.org/jira/browse/HIVE-5176
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> We need to make certain changes across the board to allow us to read/parse windows paths.
Some are escaping changes, some are being strict about how we read paths (through URL.encode/decode,
etc)
> 
> 
> Diffs
> -----
> 
>   common/src/test/org/apache/hadoop/hive/conf/TestHiveConf.java a31238b 
>   ql/src/test/org/apache/hadoop/hive/ql/WindowsPathUtil.java PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java e453f56

> 
> Diff: https://reviews.apache.org/r/16403/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message