Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37D7ACFCB for ; Thu, 20 Mar 2014 09:15:50 +0000 (UTC) Received: (qmail 65005 invoked by uid 500); 20 Mar 2014 09:15:47 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 64963 invoked by uid 500); 20 Mar 2014 09:15:46 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 64951 invoked by uid 500); 20 Mar 2014 09:15:45 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 64947 invoked by uid 99); 20 Mar 2014 09:15:44 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Mar 2014 09:15:44 +0000 Date: Thu, 20 Mar 2014 09:15:44 +0000 (UTC) From: "Hari Sankar Sivarama Subramaniyan (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-6708) ConstantVectorExpression should create copies of data objects rather than referencing them MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Sankar Sivarama Subramaniyan updated HIVE-6708: ---------------------------------------------------- Attachment: HIVE-6708-1.patch cc-ing [~jnp] for review. > ConstantVectorExpression should create copies of data objects rather than referencing them > ------------------------------------------------------------------------------------------ > > Key: HIVE-6708 > URL: https://issues.apache.org/jira/browse/HIVE-6708 > Project: Hive > Issue Type: Bug > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-6708-1.patch > > > 1. ConstantVectorExpression vector should be updated for bytecolumnvectors and decimalColumnVectors. The current code changes the reference to the vector which might be shared across multiple columns > 2. VectorizationContext.foldConstantsForUnaryExpression(ExprNodeDesc exprDesc) has a minor bug as to when to constant fold the expression. > The following code should replace the corresponding piece of code in the trunk. > .. > GenericUDF gudf = ((ExprNodeGenericFuncDesc) exprDesc).getGenericUDF(); > if (gudf instanceof GenericUDFOPNegative || gudf instanceof GenericUDFOPPositive > || castExpressionUdfs.contains(gudf.getClass()) > ... -- This message was sent by Atlassian JIRA (v6.2#6252)