Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D3D411B17 for ; Fri, 28 Mar 2014 21:56:50 +0000 (UTC) Received: (qmail 57985 invoked by uid 500); 28 Mar 2014 21:56:48 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 57943 invoked by uid 500); 28 Mar 2014 21:56:47 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 57933 invoked by uid 99); 28 Mar 2014 21:56:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Mar 2014 21:56:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2D0931D5C16; Fri, 28 Mar 2014 21:56:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2176184340466327524==" MIME-Version: 1.0 Subject: Re: Review Request 19718: Vectorized Between and IN expressions don't work with decimal, date types. From: "Jitendra Pandey" To: "Eric Hanson" Cc: "Jitendra Pandey" , "hive" Date: Fri, 28 Mar 2014 21:56:43 -0000 Message-ID: <20140328215643.14602.48708@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jitendra Pandey" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/19718/ X-Sender: "Jitendra Pandey" References: <20140327232227.14602.69098@reviews.apache.org> In-Reply-To: <20140327232227.14602.69098@reviews.apache.org> Reply-To: "Jitendra Pandey" X-ReviewRequest-Repository: hive-git --===============2176184340466327524== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19718/ ----------------------------------------------------------- (Updated March 28, 2014, 9:56 p.m.) Review request for hive and Eric Hanson. Bugs: HIVE-6752 https://issues.apache.org/jira/browse/HIVE-6752 Repository: hive-git Description ------- Vectorized Between and IN expressions don't work with decimal, date types. Diffs (updated) ----- ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 44b0c59 ql/src/gen/vectorization/ExpressionTemplates/FilterDecimalColumnBetween.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java 2229079 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 96e74a9 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDateToString.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalColumnInList.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterDecimalColumnInList.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IDecimalInExpr.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java c2240c0 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 5ebab70 ql/src/test/queries/clientpositive/vector_between_in.q PRE-CREATION ql/src/test/results/clientpositive/vector_between_in.q.out PRE-CREATION Diff: https://reviews.apache.org/r/19718/diff/ Testing ------- Thanks, Jitendra Pandey --===============2176184340466327524==--