Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3E78101E0 for ; Thu, 27 Mar 2014 19:42:44 +0000 (UTC) Received: (qmail 99735 invoked by uid 500); 27 Mar 2014 19:42:43 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 99192 invoked by uid 500); 27 Mar 2014 19:42:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 99178 invoked by uid 99); 27 Mar 2014 19:42:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Mar 2014 19:42:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C105C1D5BE5; Thu, 27 Mar 2014 19:42:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6646186222066829231==" MIME-Version: 1.0 Subject: Review Request 19747: HIVE-6547 - normalize struct Role in metastore thrift interface From: "Thejas Nair" To: "Ashutosh Chauhan" Cc: "Thejas Nair" , "hive" Date: Thu, 27 Mar 2014 19:42:37 -0000 Message-ID: <20140327194237.14602.87653@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/19747/ X-Sender: "Thejas Nair" Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============6646186222066829231== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19747/ ----------------------------------------------------------- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-6547 https://issues.apache.org/jira/browse/HIVE-6547 Repository: hive-git Description ------- As discussed in HIVE-5931, it will be cleaner to have the information about Role to role member mapping removed from the Role object, as it is not part of a logical Role. This information not relevant for actions such as creating a Role. As part of this change get_role_grants_for_principal api will be added, so that it can be used in place of list_roles, when role mapping information is desired. Also cleans up additional fields - principalname and principaltype in 'show role grant user user2" output, as that is redundant information. Also removes role createtime from this command output as that is not relevant to role grant information. Diffs ----- metastore/if/hive_metastore.thrift b3f01d6 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d5c7ba7 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 0550589 metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 47c49aa ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java e185f12 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ace6cb5 ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java bc9d47e ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java 50bd592 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 48064c4 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 2577ae5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRole.java 7f3d78a ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveRoleGrant.java 03f129a ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/GrantPrivAuthUtils.java fdbf3c3 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 03d12ca ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java 5b24578 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 7bb5a88 ql/src/test/queries/clientpositive/authorization_role_grant2.q 00a67a2 ql/src/test/results/clientnegative/authorization_fail_7.q.out 00e457d ql/src/test/results/clientnegative/authorization_role_grant.q.out de17ae9 ql/src/test/results/clientpositive/authorization_1.q.out 916125b ql/src/test/results/clientpositive/authorization_1_sql_std.q.out 2302da0 ql/src/test/results/clientpositive/authorization_5.q.out f1c07d0 ql/src/test/results/clientpositive/authorization_role_grant1.q.out 48e0f59 ql/src/test/results/clientpositive/authorization_role_grant2.q.out d08b906 ql/src/test/results/clientpositive/authorization_view_sqlstd.q.out 0a986e6 Diff: https://reviews.apache.org/r/19747/diff/ Testing ------- Thanks, Thejas Nair --===============6646186222066829231==--