Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 013B810647 for ; Fri, 21 Mar 2014 11:31:23 +0000 (UTC) Received: (qmail 7798 invoked by uid 500); 21 Mar 2014 11:31:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 7741 invoked by uid 500); 21 Mar 2014 11:31:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 7732 invoked by uid 99); 21 Mar 2014 11:31:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Mar 2014 11:31:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6694E1D55CC; Fri, 21 Mar 2014 11:31:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5949346748762854416==" MIME-Version: 1.0 Subject: Review Request 19525: Clean up math based UDFs From: "Lars Francke" To: "Lars Francke" , "hive" Date: Fri, 21 Mar 2014 11:31:16 -0000 Message-ID: <20140321113116.10647.15697@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Lars Francke" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/19525/ X-Sender: "Lars Francke" Reply-To: "Lars Francke" X-ReviewRequest-Repository: hive-git --===============5949346748762854416== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19525/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-6510 https://issues.apache.org/jira/browse/HIVE-6510 Repository: hive-git Description ------- HIVE-6327, HIVE-6246 and HIVE-6385 touched a lot of the math based UDFs. There are some code inconsistencies and warnings left. This cleans up all the problems I could find. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAcos.java 18c79a7 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAsin.java cfd5d38 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java 641bba2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCos.java bfa95ee ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java bc5e1e2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFExp.java cf6f53e ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java eb5f646 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java 7a4d8a7 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java 00dc319 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog2.java 9202258 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMath.java c1981af ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java fd1f0e3 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 6e4bee0 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java 8f757f2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSqrt.java 17094c9 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java c286619 Diff: https://reviews.apache.org/r/19525/diff/ Testing ------- Thanks, Lars Francke --===============5949346748762854416==--