Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 038C01097B for ; Tue, 11 Mar 2014 20:49:30 +0000 (UTC) Received: (qmail 95238 invoked by uid 500); 11 Mar 2014 20:49:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 94621 invoked by uid 500); 11 Mar 2014 20:49:26 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 94603 invoked by uid 99); 11 Mar 2014 20:49:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2014 20:49:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BA8DA1D4FF2; Tue, 11 Mar 2014 20:49:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4360720827154999837==" MIME-Version: 1.0 Subject: Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task From: "Mohammad Islam" To: "Ashutosh Chauhan" Cc: "Carl Steinbach" , "Mohammad Islam" , "hive" Date: Tue, 11 Mar 2014 20:49:23 -0000 Message-ID: <20140311204923.27073.99053@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mohammad Islam" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/18065/ X-Sender: "Mohammad Islam" References: <20140311203703.22644.96832@reviews.apache.org> In-Reply-To: <20140311203703.22644.96832@reviews.apache.org> Reply-To: "Mohammad Islam" X-ReviewRequest-Repository: hive-git --===============4360720827154999837== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18065/ ----------------------------------------------------------- (Updated March 11, 2014, 8:49 p.m.) Review request for hive and Ashutosh Chauhan. Changes ------- uploading the correct patch file. Bugs: HIVE-6024 https://issues.apache.org/jira/browse/HIVE-6024 Repository: hive-git Description ------- Excerpt from the JIRA: "Load data command creates an additional copy task only when its loading from local It doesn't create this additional copy task while loading from DFS though." Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8beef09 ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java a190155 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e10bdb4 ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 3dd0f6f ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION ql/src/test/results/clientpositive/input4.q.out 9b169f9 ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION ql/src/test/results/clientpositive/stats11.q.out ce1197e ql/src/test/results/clientpositive/stats3.q.out a14e449 Diff: https://reviews.apache.org/r/18065/diff/ Testing ------- Ran some existing q tests with "LOAD DATA LOCAL INPATH". Thanks, Mohammad Islam --===============4360720827154999837==--