Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6E5010797 for ; Sat, 8 Mar 2014 20:56:33 +0000 (UTC) Received: (qmail 36248 invoked by uid 500); 8 Mar 2014 20:56:32 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 36132 invoked by uid 500); 8 Mar 2014 20:56:32 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 36121 invoked by uid 99); 8 Mar 2014 20:56:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Mar 2014 20:56:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CB4861D4CA5; Sat, 8 Mar 2014 20:56:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6127148265165343025==" MIME-Version: 1.0 Subject: Review Request 18943: Make Vector Group By operator abandon grouping if too many distinct keys From: "Remus Rusanu" To: "Jitendra Pandey" , "Eric Hanson" Cc: "Remus Rusanu" , "hive" Date: Sat, 08 Mar 2014 20:56:29 -0000 Message-ID: <20140308205629.30871.18933@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Remus Rusanu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/18943/ X-Sender: "Remus Rusanu" Reply-To: "Remus Rusanu" X-ReviewRequest-Repository: hive-git --===============6127148265165343025== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18943/ ----------------------------------------------------------- Review request for hive, Eric Hanson and Jitendra Pandey. Bugs: HIVE-6222 https://issues.apache.org/jira/browse/HIVE-6222 Repository: hive-git Description ------- See HIVE-6222 Diffs ----- ql/src/gen/vectorization/UDAFTemplates/VectorUDAFAvg.txt 547a60a ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMax.txt dcc1dfb ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt de9a84c ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxString.txt 1f8b28c ql/src/gen/vectorization/UDAFTemplates/VectorUDAFSum.txt cb0be33 ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVar.txt 49b0edd ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVarDecimal.txt e626161 ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java c4c85fa ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAggregationBufferRow.java 7aa4b11 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 4568496 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java a2a7266 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java bd6c24b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorUtilBatchObjectPool.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorAggregateExpression.java 1836169 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java 8418587 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFCount.java 086f91f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFCountStar.java 4926f6c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFSumDecimal.java a931887 Diff: https://reviews.apache.org/r/18943/diff/ Testing ------- Manually tested. I plan to add test cases in TestVGBy Thanks, Remus Rusanu --===============6127148265165343025==--