Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============2860868280866032623=="
MIME-Version: 1.0
Subject: Re: Review Request 18925: HIVE-6575 select * fails on parquet table
 with map
 datatype
From: "Szehon Ho" <szehon@cloudera.com>
To: "justin coffey" <j.coffey@criteo.com>,
 "Xuefu Zhang" <xzhang@cloudera.com>,
 "Brock Noland" <brock@cloudera.com>
Cc: "Szehon Ho" <szehon@cloudera.com>, "hive" <dev@hive.apache.org>
Date: Sat, 08 Mar 2014 00:01:16 -0000
Message-ID: <20140308000116.2625.55936@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Szehon Ho" <noreply@reviews.apache.org>
References: <20140307222011.2625.4474@reviews.apache.org>
In-Reply-To: <20140307222011.2625.4474@reviews.apache.org>
Reply-To: "Szehon Ho" <szehon@cloudera.com>

--===============2860868280866032623==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18925/
-----------------------------------------------------------

(Updated March 8, 2014, 12:01 a.m.)


Review request for hive, Brock Noland, justin coffey, and Xuefu Zhang.


Changes
-------

Fixed the styling of generated equals code.  I looked at the proposed refactor, I think the simplication you suggested would hit NPE if this.keyInspector is null and other.keyInspector != null.  Given that you would need a few more boolean statements in that line to make it correct, it seems that the current one is probably the cleanest to look at.


Repository: hive-git


Description
-------

The issue is, as part of select * query, a DeepParquetHiveMapInspector is used for one column of an overall parquet-table struct object inspector.  

The problem lies in the ObjectInspectorFactory's cache for struct object inspector.  For performance, there is a cache keyed on an array list, of all object inspectors of columns.  The second time the query is run, it attempts to lookup cached struct inspector.  But when the hashmap looks up the part of the key consisting of the DeepParquetHiveMapInspector, java calls .equals against the existing DeepParquetHivemapInspector.  This fails, as the .equals method casted the "other" to a "StandardParquetHiveInspector".

Regenerating the .equals and .hashcode from eclipse.  

Also adding one more check in .equals before casting, to handle the case if another class of object inspector gets hashed to the same hashcode in the cache.  Then java would call .equals against the other, which in this case is not of the same class.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/AbstractParquetMapInspector.java 1d72747 

Diff: https://reviews.apache.org/r/18925/diff/


Testing
-------

Manual testing.


Thanks,

Szehon Ho


--===============2860868280866032623==--