Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 361AC104DC for ; Mon, 3 Mar 2014 22:16:08 +0000 (UTC) Received: (qmail 29064 invoked by uid 500); 3 Mar 2014 22:16:06 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 28943 invoked by uid 500); 3 Mar 2014 22:16:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 28933 invoked by uid 99); 3 Mar 2014 22:16:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Mar 2014 22:16:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AAB001D4B54; Mon, 3 Mar 2014 22:16:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7160909419732527076==" MIME-Version: 1.0 Subject: Re: Review Request 17471: HIVE-6325: Enable using multiple concurrent sessions in tez From: "Gunther Hagleitner" To: "Vikram Dixit Kumaraswamy" , "Gunther Hagleitner" , "hive" Date: Mon, 03 Mar 2014 22:16:02 -0000 Message-ID: <20140303221602.10116.8013@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gunther Hagleitner" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17471/ X-Sender: "Gunther Hagleitner" References: <20140228022520.1890.11937@reviews.apache.org> In-Reply-To: <20140228022520.1890.11937@reviews.apache.org> Reply-To: "Gunther Hagleitner" X-ReviewRequest-Repository: hive-git --===============7160909419732527076== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17471/#review36039 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java can you remove trailing ws in the files. This shouldn't require a new run of the tests... service/src/java/org/apache/hive/service/server/HiveServer2.java i believe this should be hidden behind conf check - Gunther Hagleitner On Feb. 28, 2014, 2:25 a.m., Vikram Dixit Kumaraswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17471/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 2:25 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6325 > https://issues.apache.org/jira/browse/HIVE-6325 > > > Repository: hive-git > > > Description > ------- > > Enable using multiple concurrent sessions in tez. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6802b4d > conf/hive-default.xml.template 0b86b9c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java b8552a3 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java bef5ba3 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 16e9166 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java 8700c5b > > Diff: https://reviews.apache.org/r/17471/diff/ > > > Testing > ------- > > Added multi-threaded junit tests. > > > Thanks, > > Vikram Dixit Kumaraswamy > > --===============7160909419732527076==--