Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD45110F06 for ; Sun, 2 Mar 2014 00:43:24 +0000 (UTC) Received: (qmail 8655 invoked by uid 500); 2 Mar 2014 00:43:22 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 8583 invoked by uid 500); 2 Mar 2014 00:43:21 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 8348 invoked by uid 99); 2 Mar 2014 00:43:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Mar 2014 00:43:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 96F191D4AEF; Sun, 2 Mar 2014 00:43:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4589141570662852484==" MIME-Version: 1.0 Subject: Re: Review Request 18588: sql std auth - add command to change owner of database From: "Thejas Nair" To: "Ashutosh Chauhan" Cc: "Thejas Nair" , "hive" Date: Sun, 02 Mar 2014 00:43:17 -0000 Message-ID: <20140302004317.8004.52264@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/18588/ X-Sender: "Thejas Nair" References: <20140227213354.9913.91318@reviews.apache.org> In-Reply-To: <20140227213354.9913.91318@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============4589141570662852484== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18588/ ----------------------------------------------------------- (Updated March 2, 2014, 12:43 a.m.) Review request for hive and Ashutosh Chauhan. Changes ------- HIVE-6440.3.patch - more test updates. Bugs: HIVE-6440 https://issues.apache.org/jira/browse/HIVE-6440 Repository: hive-git Description ------- It should be possible to change the owner of a database once it is created. Also includes a small change to authorize drop database, as it is better tested with this alter-db-owner functionality. Diffs (updated) ----- hbase-handler/src/test/results/negative/cascade_dbdrop_hadoop20.q.out c5bfd6a itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 7fbb67e metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java d60cb1b ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4310ab8 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 2484576 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 8356155 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 129c6c6 ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 6bf2a17 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java b1d3371 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationParseUtils.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java 4dbe78c ql/src/java/org/apache/hadoop/hive/ql/plan/AlterDatabaseDesc.java 16bb95b ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java e661f00 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java f1671ba ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java c43bcea ql/src/test/queries/clientnegative/authorization_alter_db_owner.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_alter_db_owner_default.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_drop_db_cascade.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_drop_db_empty.q PRE-CREATION ql/src/test/queries/clientpositive/alter_db_owner.q PRE-CREATION ql/src/test/results/clientnegative/authorization_alter_db_owner.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_alter_db_owner_default.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_drop_db_cascade.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_drop_db_empty.q.out PRE-CREATION ql/src/test/results/clientpositive/alter_db_owner.q.out PRE-CREATION ql/src/test/results/clientpositive/database.q.out cdaa405 ql/src/test/results/clientpositive/database_drop.q.out 3128561 ql/src/test/results/clientpositive/drop_database_removes_partition_dirs.q.out 475d3d0 ql/src/test/results/clientpositive/input46.q.out a891362 Diff: https://reviews.apache.org/r/18588/diff/ Testing ------- Thanks, Thejas Nair --===============4589141570662852484==--