hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6708) ConstantVectorExpression should create copies of data objects rather than referencing them
Date Wed, 26 Mar 2014 20:54:15 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948442#comment-13948442
] 

Harish Butani commented on HIVE-6708:
-------------------------------------

I see its already in; +1 for 0.13

> ConstantVectorExpression should create copies of data objects rather than referencing
them
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-6708
>                 URL: https://issues.apache.org/jira/browse/HIVE-6708
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>             Fix For: 0.13.0
>
>         Attachments: HIVE-6708-1.patch, HIVE-6708-3.patch, HIVE-6708-4.patch, HIVE-6708.2.patch
>
>
> 1. ConstantVectorExpression vector should be updated for bytecolumnvectors and decimalColumnVectors.
The current code changes the reference to the vector which might be shared across multiple
columns
> 2. VectorizationContext.foldConstantsForUnaryExpression(ExprNodeDesc exprDesc) has a
minor bug as to when to constant fold the expression.
> The following code should replace the corresponding piece of code in the trunk.
> ..
>     GenericUDF gudf = ((ExprNodeGenericFuncDesc) exprDesc).getGenericUDF();
>     if (gudf instanceof GenericUDFOPNegative || gudf instanceof GenericUDFOPPositive
>         || castExpressionUdfs.contains(gudf.getClass())
> ... 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message