hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6594) UnsignedInt128 addition does not increase internal int array count resulting in corrupted values during serialization
Date Mon, 10 Mar 2014 06:11:43 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925477#comment-13925477
] 

Hive QA commented on HIVE-6594:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12633542/HIVE-6594.2.patch

{color:green}SUCCESS:{color} +1 5375 tests passed

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1685/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1685/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12633542

> UnsignedInt128 addition does not increase internal int array count resulting in corrupted
values during serialization
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-6594
>                 URL: https://issues.apache.org/jira/browse/HIVE-6594
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.13.0
>            Reporter: Remus Rusanu
>            Assignee: Remus Rusanu
>         Attachments: HIVE-6594.1.patch, HIVE-6594.2.patch
>
>
> Discovered this while investigating why my fix for HIVE-6222 produced diffs. I discovered
that Decimal128.addDestructive does not adjust the internal count when an the number of relevant
ints increases. Since this count is used in the fast HiveDecimalWriter conversion code, the
results are off. 
> The root cause is UnsignedDecimal128.differenceInternal does not do an updateCount()
on the result.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message