hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz (JIRA)" <>
Subject [jira] [Commented] (HIVE-6331) HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
Date Mon, 17 Mar 2014 05:13:44 GMT


Lefty Leverenz commented on HIVE-6331:

Trivial review comments:

1.  "support" should be "supports" since UDAF is singular:
+ * Optional for a UDAF class (by implementing these two methods, the user declares
+ * that the UDAF support partial aggregations):

2.  Second <li> should be indented like the first one:

+ * <ol>
+ *   <li>Implement a single method called {@code evaluatePartial} that returns the
PARTIAL aggregation result.
+ * {@code evaluatePartial} should never return {@code null} or an Exception will be thrown.</li>
+ * <li>Implement a single method called {@code aggregatePartial} that takes a PARTIAL

> HIVE-5279 deprecated UDAF class without explanation/documentation/alternative
> -----------------------------------------------------------------------------
>                 Key: HIVE-6331
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-5279.1.patch
> HIVE-5279 added a @Deprecated annotation to the {{UDAF}} class. The comment in that class
says {quote}UDAF classes are REQUIRED to inherit from this class.{quote}
> One of these two needs to be updated. Either remove the annotation or document why it
was deprecated and what to use instead.
> Unfortunately [~navis] did not leave any documentation about his intentions.
> I'm happy to provide a patch once I know the intentions.

This message was sent by Atlassian JIRA

View raw message