hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5652) Improve JavaDoc of UDF class
Date Thu, 20 Mar 2014 19:55:43 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942200#comment-13942200
] 

Swarnim Kulkarni commented on HIVE-5652:
----------------------------------------

Some minor comments:

1. Add "return" on getRequiredJars and getRequiredFiles method. Could would be nice to specify
that the default implementation returns null.
2. "GenericUDF" -> link(GenericUDF) for getRequiredJars and getRequiredFiles methods
3. Nit: A simple description of what required jars and required files are would be very helpful(atleast
from a perspective of a newbie attempting to write a brand new UDF implementation).

> Improve JavaDoc of UDF class
> ----------------------------
>
>                 Key: HIVE-5652
>                 URL: https://issues.apache.org/jira/browse/HIVE-5652
>             Project: Hive
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Trivial
>         Attachments: HIVE-5652.1.patch, HIVE-5652.2.patch
>
>
> I think the JavaDoc for the UDF class can be improved. I'll attach a patch shortly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message