hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Edward Capriolo <edlinuxg...@gmail.com>
Subject Re: Proposal to switch to pull requests
Date Sun, 09 Mar 2014 19:25:56 GMT
I do not think we want Pull Requests coming at us. Better way is let
someone open a git branch for the changes, then we review and merge the
branch.


On Sat, Mar 8, 2014 at 4:25 PM, Brock Noland <brock@cloudera.com> wrote:

> In my read of the Apache git - github integration blog post we cannot use
> pull requests as patches. Just that we'll be notified of them and could
> perhaps use them as code review.
>
> One additional item I think we should investigate is disabling merge
> commits on trunk and feature branches.
> On Mar 7, 2014 7:57 PM, "Edward Capriolo" <edlinuxguru@gmail.com> wrote:
>
> > We need to keep patches in Jira I feel. We have gotten better on the
> > documentation front but having a patch in the jira is critical I feel. We
> > must at least have a perma link to the changes.
> >
> >
> > On Fri, Mar 7, 2014 at 8:40 PM, Sergey Shelukhin <sergey@hortonworks.com
> > >wrote:
> >
> > > +1 to git!
> > >
> > >
> > > On Fri, Mar 7, 2014 at 12:46 PM, Xuefu Zhang <xzhang@cloudera.com>
> > wrote:
> > >
> > > > Switching to git from svn seems to be a proposal slightly different
> > from
> > > > that of switching to pull request from the head of the thread.
> > Personally
> > > > I'm +1 to git, but I think patches are very portable and widely
> adopted
> > > in
> > > > Hadoop ecosystem and we should keep the practice. Thus, +1 to that
> > also.
> > > >
> > > > --Xuefu
> > > >
> > > >
> > > > On Fri, Mar 7, 2014 at 12:27 PM, Gunther Hagleitner <
> > > > ghagleitner@hortonworks.com> wrote:
> > > >
> > > > > Once Prasad's loop finishes I'd like to add my +1 too.
> > > > >
> > > > >
> > > > > On Fri, Mar 7, 2014 at 11:44 AM, Vaibhav Gumashta <
> > > > > vgumashta@hortonworks.com
> > > > > > wrote:
> > > > >
> > > > > > +1 for moving to git!
> > > > > >
> > > > > > Thanks,
> > > > > > --Vaibhav
> > > > > >
> > > > > >
> > > > > > On Fri, Mar 7, 2014 at 9:46 AM, Prasad Mujumdar <
> > > prasadm@cloudera.com
> > > > > > >wrote:
> > > > > >
> > > > > > >   while (true) {
> > > > > > >    +1
> > > > > > >   }
> > > > > > >
> > > > > > >   +1  // another, just in case ;)
> > > > > > >
> > > > > > > thanks
> > > > > > > Prasad
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Mar 7, 2014 at 6:47 AM, kulkarni.swarnim@gmail.com
<
> > > > > > > kulkarni.swarnim@gmail.com> wrote:
> > > > > > >
> > > > > > > > +1
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Mar 7, 2014 at 1:05 AM, Thejas Nair <
> > > > thejas@hortonworks.com>
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Should we start with moving our primary source
code
> > repository
> > > > from
> > > > > > > > > svn to git ? I feel git is more powerful and
easy to use
> > (once
> > > > you
> > > > > go
> > > > > > > > > past the learning curve!).
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, Mar 5, 2014 at 7:39 AM, Brock Noland
<
> > > brock@cloudera.com
> > > > >
> > > > > > > wrote:
> > > > > > > > > > Personally I prefer the Github workflow,
but I believe
> > there
> > > > have
> > > > > > > been
> > > > > > > > > > some challenges with that since the source
for apache
> > > projects
> > > > > must
> > > > > > > be
> > > > > > > > > > stored in apache source control (git or
svn).
> > > > > > > > > >
> > > > > > > > > > Relevent:
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
> > > > > > > > > >
> > > > > > > > > > On Wed, Mar 5, 2014 at 9:19 AM,
> kulkarni.swarnim@gmail.com
> > > > > > > > > > <kulkarni.swarnim@gmail.com> wrote:
> > > > > > > > > >> Hello,
> > > > > > > > > >>
> > > > > > > > > >> Since we have a nice mirrored git repository
for
> hive[1],
> > > any
> > > > > > > specific
> > > > > > > > > >> reason why we can't switch to doing
pull requests
> instead
> > of
> > > > > > > patches?
> > > > > > > > > IMHO
> > > > > > > > > >> pull requests are awesome for peer review
plus it is
> also
> > > very
> > > > > > easy
> > > > > > > to
> > > > > > > > > keep
> > > > > > > > > >> track of JIRAs with open pull requests
instead of
> looking
> > > for
> > > > > > JIRAs
> > > > > > > > in a
> > > > > > > > > >> "Patch Available" state. Also since
they get updated
> > > > > > automatically,
> > > > > > > it
> > > > > > > > > is
> > > > > > > > > >> also very easy to see if a review comment
made by a
> > reviewer
> > > > was
> > > > > > > > > addressed
> > > > > > > > > >> properly or not.
> > > > > > > > > >>
> > > > > > > > > >> Thoughts?
> > > > > > > > > >>
> > > > > > > > > >> Thanks,
> > > > > > > > > >>
> > > > > > > > > >> [1] https://github.com/apache/hive
> > > > > > > > > >>
> > > > > > > > > >> --
> > > > > > > > > >> Swarnim
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Apache MRUnit - Unit testing MapReduce -
> > > > > http://mrunit.apache.org
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > CONFIDENTIALITY NOTICE
> > > > > > > > > NOTICE: This message is intended for the use
of the
> > individual
> > > or
> > > > > > > entity
> > > > > > > > to
> > > > > > > > > which it is addressed and may contain information
that is
> > > > > > confidential,
> > > > > > > > > privileged and exempt from disclosure under applicable
law.
> > If
> > > > the
> > > > > > > reader
> > > > > > > > > of this message is not the intended recipient,
you are
> hereby
> > > > > > notified
> > > > > > > > that
> > > > > > > > > any printing, copying, dissemination, distribution,
> > disclosure
> > > or
> > > > > > > > > forwarding of this communication is strictly
prohibited. If
> > you
> > > > > have
> > > > > > > > > received this communication in error, please
contact the
> > sender
> > > > > > > > immediately
> > > > > > > > > and delete it from your system. Thank You.
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Swarnim
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > > --
> > > > > > CONFIDENTIALITY NOTICE
> > > > > > NOTICE: This message is intended for the use of the individual
or
> > > > entity
> > > > > to
> > > > > > which it is addressed and may contain information that is
> > > confidential,
> > > > > > privileged and exempt from disclosure under applicable law.
If
> the
> > > > reader
> > > > > > of this message is not the intended recipient, you are hereby
> > > notified
> > > > > that
> > > > > > any printing, copying, dissemination, distribution, disclosure
or
> > > > > > forwarding of this communication is strictly prohibited. If
you
> > have
> > > > > > received this communication in error, please contact the sender
> > > > > immediately
> > > > > > and delete it from your system. Thank You.
> > > > > >
> > > > >
> > > > > --
> > > > > CONFIDENTIALITY NOTICE
> > > > > NOTICE: This message is intended for the use of the individual or
> > > entity
> > > > to
> > > > > which it is addressed and may contain information that is
> > confidential,
> > > > > privileged and exempt from disclosure under applicable law. If the
> > > reader
> > > > > of this message is not the intended recipient, you are hereby
> > notified
> > > > that
> > > > > any printing, copying, dissemination, distribution, disclosure or
> > > > > forwarding of this communication is strictly prohibited. If you
> have
> > > > > received this communication in error, please contact the sender
> > > > immediately
> > > > > and delete it from your system. Thank You.
> > > > >
> > > >
> > >
> > > --
> > > CONFIDENTIALITY NOTICE
> > > NOTICE: This message is intended for the use of the individual or
> entity
> > to
> > > which it is addressed and may contain information that is confidential,
> > > privileged and exempt from disclosure under applicable law. If the
> reader
> > > of this message is not the intended recipient, you are hereby notified
> > that
> > > any printing, copying, dissemination, distribution, disclosure or
> > > forwarding of this communication is strictly prohibited. If you have
> > > received this communication in error, please contact the sender
> > immediately
> > > and delete it from your system. Thank You.
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message