hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dilli dorai" <dilli.do...@gmail.com>
Subject Re: Review Request 19801: review request for HIVE-6738, HiveServer2 secure Thrift/HTTP needs to accept doAs parameter from proxying intermediary
Date Sat, 29 Mar 2014 01:10:45 GMT


> On March 28, 2014, 11:43 p.m., Vaibhav Gumashta wrote:
> > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java, line
82
> > <https://reviews.apache.org/r/19801/diff/1/?file=539920#file539920line82>
> >
> >     Can we use proxyUserNameParam for doAsQueryParam? doAs in hive world is different
than proxy user like we discussed offline.

First, thanks for the review.
I think the query parameter name has to be "doAs", case does not matter.
That is the interface used by other HTTP services of Hadoop echo system.


> On March 28, 2014, 11:43 p.m., Vaibhav Gumashta wrote:
> > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java, line
309
> > <https://reviews.apache.org/r/19801/diff/1/?file=539920#file539920line309>
> >
> >     Similar to the previous comment: I think it'll be good to change the method
name to getProxyUserNameParam from getDoAsQueryParam.

See the comment above.


- dilli


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19801/#review38968
-----------------------------------------------------------


On March 28, 2014, 9:08 p.m., dilli dorai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19801/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 9:08 p.m.)
> 
> 
> Review request for hive, Thejas Nair and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-6738
>     https://issues.apache.org/jira/browse/HIVE-6738
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see the jira HIVE-6738
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 7f6687e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 58f3e3b 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java c579db5

> 
> Diff: https://reviews.apache.org/r/19801/diff/
> 
> 
> Testing
> -------
> 
> see the attachment to Jira HIVE-6738
> https://issues.apache.org/jira/secure/attachment/12637059/hive-6738-req-impl-verify.md
> 
> 
> Thanks,
> 
> dilli dorai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message