hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 19801: review request for HIVE-6738, HiveServer2 secure Thrift/HTTP needs to accept doAs parameter from proxying intermediary
Date Sat, 29 Mar 2014 00:08:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19801/#review38974
-----------------------------------------------------------



service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
<https://reviews.apache.org/r/19801/#comment71355>

    I think we should set proxyUser from the threadlocal only when HS2 is running in http
mode - this will avoid any future confusion while development. This is the block you can use:
    
    if (hiveConf.getVar(HiveConf.ConfVars.HIVE_SERVER2_TRANSPORT_MODE).equalsIgnoreCase("http"))
{
    }


- Vaibhav Gumashta


On March 28, 2014, 9:08 p.m., dilli dorai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19801/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 9:08 p.m.)
> 
> 
> Review request for hive, Thejas Nair and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-6738
>     https://issues.apache.org/jira/browse/HIVE-6738
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see the jira HIVE-6738
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 7f6687e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 58f3e3b 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java c579db5

> 
> Diff: https://reviews.apache.org/r/19801/diff/
> 
> 
> Testing
> -------
> 
> see the attachment to Jira HIVE-6738
> https://issues.apache.org/jira/secure/attachment/12637059/hive-6738-req-impl-verify.md
> 
> 
> Thanks,
> 
> dilli dorai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message