hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke" <>
Subject Re: Review Request 19525: Clean up math based UDFs
Date Sat, 22 Mar 2014 13:28:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 22, 2014, 1:28 p.m.)

Review request for hive.


Second version addressing a comment as well as formatting the Javadocs consistently. I've
also moved the null check to UDFMath itself as it's common to all subclasses.

Bugs: HIVE-6510

Repository: hive-git


HIVE-6327, HIVE-6246 and HIVE-6385 touched a lot of the math based UDFs. There are some code
inconsistencies and warnings left. This cleans up all the problems I could find.

Diffs (updated)

  ql/src/java/org/apache/hadoop/hive/ql/udf/ 18c79a7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ cfd5d38 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 641bba2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ f277ea2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ bfa95ee 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ bc5e1e2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ cf6f53e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ eb5f646 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 7a4d8a7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 00dc319 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 9202258 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ c1981af 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ fd1f0e3 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 6e4bee0 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 8f757f2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ 17094c9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/ c286619 




Lars Francke

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message