hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 19503: JDBC ResultSet fails to get value by qualified projection name
Date Fri, 21 Mar 2014 21:23:25 GMT


> On March 20, 2014, 10:32 p.m., Harish Butani wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 9425
> > <https://reviews.apache.org/r/19503/diff/1/?file=530722#file530722line9425>
> >
> >     Can you verify that there is no issue if table/column names have the '.' character.
Sounds like jdbc treats column names as a string, so this should be ok.

1. JDBC ResultSet treats label as string.
2. I don't think the qualifier would get anything more than the table name and hence there
should only be one ".".


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19503/#review37998
-----------------------------------------------------------


On March 20, 2014, 10:24 p.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19503/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 10:24 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: hive-6687
>     https://issues.apache.org/jira/browse/hive-6687
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> JDBC ResultSet fails to get value by qualified projection name
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java dac62d5

>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java c91df83 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1e427f 
> 
> Diff: https://reviews.apache.org/r/19503/diff/
> 
> 
> Testing
> -------
> 
>   
> 
> 
> Thanks,
> 
> Harish Butani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message