hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 19322: HIVE-6685 Beeline throws ArrayIndexOutOfBoundsException for mismatched arguments
Date Wed, 19 Mar 2014 01:25:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19322/
-----------------------------------------------------------

(Updated March 19, 2014, 1:25 a.m.)


Review request for hive and Xuefu Zhang.


Changes
-------

Refactored the arg-passing from manual list iteration, to use a simple extension of GNUParser.
 Mostly borrowing the code from HiveCLI.

It is needed to extend the GNUParser because they dont support unknown arguments.  In beeline
case, these are the 'property-files' and the reflectively-set BeelineOpts like 'autoCommit',
etc.

Adding a unit test to verify the parsing doesn't break anything.


Bugs: HIVE-6685
    https://issues.apache.org/jira/browse/HIVE-6685


Repository: hive-git


Description
-------

Improving the error-handling in ArrayIndexOutOfBoundsException of Beeline.


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 3482186 
  beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java PRE-CREATION 

Diff: https://reviews.apache.org/r/19322/diff/


Testing
-------

Manual test.  Now, in this scenario it will display the usage like:

beeline -u
Usage: java org.apache.hive.cli.beeline.BeeLine 
   -u <database url>               the JDBC URL to connect to
   -n <username>                   the username to connect as
   -p <password>                   the password to connect as
...


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message