hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 19265: HIVE-6677: HBaseSerDe needs to be refactored
Date Tue, 18 Mar 2014 00:44:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19265/#review37516
-----------------------------------------------------------


Looks fine to me.
A minor formatting nits, feel free to ignore.


hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
<https://reviews.apache.org/r/19265/#comment69059>

    Nit: whitespace



hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java
<https://reviews.apache.org/r/19265/#comment69060>

    Nit: indentation


- Prasad Mujumdar


On March 16, 2014, 5:33 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19265/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 5:33 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6677
>     https://issues.apache.org/jira/browse/HIVE-6677
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Pure refactoring. For the purpose of what is described in the JIRA. Mostly, separating
key serialization from column serialization. When possible, static methods are used. Some
code cleanup is made. All serde properties, including those dedicated for HBaseSerde, is captured
in class HBaseSerDeParameters.
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java PRE-CREATION

>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 29e5da5

>   hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java db69ae5

> 
> Diff: https://reviews.apache.org/r/19265/diff/
> 
> 
> Testing
> -------
> 
> No new tests. Test suite passed successfully.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message