hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 19247: hive.optimize.index.filter breaks non-index where with HBaseStorageHandler
Date Sat, 15 Mar 2014 21:57:17 GMT


> On March 15, 2014, 12:19 a.m., Xuefu Zhang wrote:
> > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java,
line 275
> > <https://reviews.apache.org/r/19247/diff/1/?file=520087#file520087line275>
> >
> >     Since the problem comes from upper layer, I'm wondering if this should be fixed
there instead.

Yeah I think ideally we should support this case. However, it might make sense to commit a
temporary fix and resolve the larger issue in a follow-on jira.

Nick, how impactful is this to the hbase use case?


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19247/#review37298
-----------------------------------------------------------


On March 14, 2014, 11:53 p.m., nick dimiduk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19247/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 11:53 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6650
>     https://issues.apache.org/jira/browse/HIVE-6650
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> With the above enabled, where clauses including non-rowkey columns cannot be used with
the HBaseStorageHandler. See ticket for full details.
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
704fcb9 
>   hbase-handler/src/test/queries/positive/hbase_pushdown.q 69a4536 
>   hbase-handler/src/test/results/positive/hbase_pushdown.q.out ee9e20c 
> 
> Diff: https://reviews.apache.org/r/19247/diff/
> 
> 
> Testing
> -------
> 
> Included patch allows said query to run. Waiting on build bot for test suite.
> 
> 
> Thanks,
> 
> nick dimiduk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message