hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remus Rusanu" <rem...@microsoft.com>
Subject Review Request 18943: Make Vector Group By operator abandon grouping if too many distinct keys
Date Sat, 08 Mar 2014 20:56:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18943/
-----------------------------------------------------------

Review request for hive, Eric Hanson and Jitendra Pandey.


Bugs: HIVE-6222
    https://issues.apache.org/jira/browse/HIVE-6222


Repository: hive-git


Description
-------

See HIVE-6222


Diffs
-----

  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFAvg.txt 547a60a 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMax.txt dcc1dfb 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt de9a84c 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxString.txt 1f8b28c 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFSum.txt cb0be33 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVar.txt 49b0edd 
  ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVarDecimal.txt e626161 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java c4c85fa 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAggregationBufferRow.java 7aa4b11

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java 4568496 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java a2a7266 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java bd6c24b

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorUtilBatchObjectPool.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorAggregateExpression.java
1836169 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java
8418587 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFCount.java
086f91f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFCountStar.java
4926f6c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFSumDecimal.java
a931887 

Diff: https://reviews.apache.org/r/18943/diff/


Testing
-------

Manually tested. I plan to add test cases in TestVGBy


Thanks,

Remus Rusanu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message