hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 18914: HIVE-6457 - Ensure Parquet integration has good error messages for data types not supported
Date Fri, 07 Mar 2014 19:28:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18914/#review36561
-----------------------------------------------------------

Ship it!


lgtm, +1 (non-binding)

- Szehon Ho


On March 7, 2014, 7:26 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18914/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 7:26 p.m.)
> 
> 
> Review request for hive, Szehon Ho and Xuefu Zhang.
> 
> 
> Bugs: HIVE-6457
>     https://issues.apache.org/jira/browse/HIVE-6457
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Improved error messages for unsupported types.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java
a2c7fe0 
>   ql/src/test/queries/clientnegative/parquet_char.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/parquet_date.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/parquet_decimal.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/parquet_timestamp.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/parquet_varchar.q PRE-CREATION 
>   ql/src/test/results/clientnegative/parquet_char.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/parquet_date.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/parquet_decimal.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/parquet_timestamp.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/parquet_varchar.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18914/diff/
> 
> 
> Testing
> -------
> 
> New tests pass.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message