hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 17302: HIVE-6012: restore backward compatibility of arithmetic operations
Date Thu, 06 Mar 2014 01:32:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17302/
-----------------------------------------------------------

(Updated March 6, 2014, 1:32 a.m.)


Review request for hive.


Changes
-------

patch v5, rebased with trunk


Bugs: HIVE-6012
    https://issues.apache.org/jira/browse/HIVE-6012


Repository: hive-git


Description
-------

Change return types back to Hive-0.12 behavior for the following math operators:
int / int -> decimal, used to be double in Hive-0.12
float + int -> double, used to be float in Hive-0.12
float + float -> double, used to be float in Hive-0.12
float * int -> double, used to be float in Hive-0.12
float * float -> double, used to be float in Hive-0.12


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5dbd1a5 
  common/src/java/org/apache/hive/common/HiveCompat.java PRE-CREATION 
  conf/hive-default.xml.template a52be2b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b9a5d38 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 1813b64 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java 28b5ffd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java 96f970e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExpressionEvaluator.java 65181e4 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java e894b54 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java d7285d9 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java ef17eb5 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java 56472f0

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPNumeric.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java 6193257 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java 702e3e7 
  ql/src/test/queries/clientpositive/ansi_sql_arithmetic.q PRE-CREATION 
  ql/src/test/results/clientpositive/ansi_sql_arithmetic.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/decimal_udf.q.out 09c410a 
  ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 6f948ed 
  ql/src/test/results/clientpositive/udf_pmod.q.out 7766304 
  ql/src/test/results/clientpositive/vectorization_15.q.out 8c6a6d8 
  ql/src/test/results/clientpositive/vectorization_5.q.out abcafd2 
  ql/src/test/results/clientpositive/vectorization_short_regress.q.out 8c22391 
  ql/src/test/results/clientpositive/windowing_expressions.q.out 604c56c 

Diff: https://reviews.apache.org/r/17302/diff/


Testing
-------


Thanks,

Jason Dere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message