hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shivaraju Gowda" <shiv...@cisco.com>
Subject Re: Review Request 18757: HIVE-6486 Support secure Subject.doAs() in HiveServer2 JDBC client
Date Wed, 05 Mar 2014 18:08:07 GMT


> On March 4, 2014, 11:16 p.m., Thejas Nair wrote:
> > http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java,
line 70
> > <https://reviews.apache.org/r/18757/diff/1/?file=510309#file510309line70>
> >
> >     can you take fix this indentation ? is it having tabs instead of spaces ?
> >

Yes there is a tab in there, both(this and the one below) of these blocks are eclipse indented(cntrl+i).
However, the rest of the code has different indentation so it looks little odd. I will have
to indent the entire file to be consistent.


- Shivaraju


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18757/#review36205
-----------------------------------------------------------


On March 4, 2014, 3:14 p.m., Shivaraju Gowda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18757/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 3:14 p.m.)
> 
> 
> Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-6486
>     https://issues.apache.org/jira/browse/HIVE-6486
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> Support secure Subject.doAs() in HiveServer2 JDBC client.
> 
> Original review: https://reviews.apache.org/r/18464/
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
1574208 
>   http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java
1574208 
>   http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18757/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Shivaraju Gowda
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message