hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 18065: HIVE-6024 Load data local inpath unnecessarily creates a copy task
Date Sat, 01 Mar 2014 00:08:19 GMT


> On Feb. 28, 2014, 10:11 a.m., Carl Steinbach wrote:
> > ql/src/test/queries/clientpositive/load_local_dir_test.q, line 2
> > <https://reviews.apache.org/r/18065/diff/4/?file=506815#file506815line2>
> >
> >     This test passes with or without the rest of the patch. It doesn't seem to demonstrate
any change in behavior.

Yes. This JIRA is to change the hive internal data movement for HQL 'LOAD LOCAL ...' -- no
new feature is added.
I understood Ashutosh's concern to verify whether this new internal change would break the
HQL like LOAD LOCAL from a *directory*. I didn't find any existing .q file that covered this
test. Therefore added a new one to make sure existing behavior doesn't break.


- Mohammad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18065/#review35771
-----------------------------------------------------------


On Feb. 28, 2014, 8:03 a.m., Mohammad Islam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18065/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:03 a.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6024
>     https://issues.apache.org/jira/browse/HIVE-6024
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Excerpt from the JIRA:
> "Load data command creates an additional copy task only when its loading from local It
doesn't create this additional copy task while loading from DFS though."
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
8beef09 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java ed7787d 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 05a2da7 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 8318be1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 59aeb96 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java 407450e 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 5991aae 
>   ql/src/test/queries/clientpositive/load_local_dir_test.q PRE-CREATION 
>   ql/src/test/results/clientpositive/load_local_dir_test.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18065/diff/
> 
> 
> Testing
> -------
> 
> Ran some existing q tests with "LOAD DATA LOCAL INPATH".
> 
> 
> Thanks,
> 
> Mohammad Islam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message