Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 746CB1003F for ; Fri, 28 Feb 2014 17:00:41 +0000 (UTC) Received: (qmail 73083 invoked by uid 500); 28 Feb 2014 17:00:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 72855 invoked by uid 500); 28 Feb 2014 17:00:32 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 72745 invoked by uid 500); 28 Feb 2014 17:00:31 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 72535 invoked by uid 99); 28 Feb 2014 17:00:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Feb 2014 17:00:26 +0000 Date: Fri, 28 Feb 2014 17:00:26 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-3938) Hive MetaStore should send a single AddPartitionEvent for atomically added partition-set. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915999#comment-13915999 ] Ashutosh Chauhan commented on HIVE-3938: ---------------------------------------- +1 [~mithun] Can you re-upload the patch with name HIVE-3938.patch That way Hive QA will pick it up to run test suite. One thing which is disturbing in current code base is (which existed even before this patch) is we are running these pre and post hooks within transaction. General wisdom is to never make calls to foreign system (like MsgBus in our case) from within database transaction. We should try to improve this, though thats probably a topic for another jira. > Hive MetaStore should send a single AddPartitionEvent for atomically added partition-set. > ----------------------------------------------------------------------------------------- > > Key: HIVE-3938 > URL: https://issues.apache.org/jira/browse/HIVE-3938 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 0.10.0, 0.11.0, 0.12.0 > Reporter: Mithun Radhakrishnan > Assignee: Mithun Radhakrishnan > Attachments: HIVE-3938.trunk.2.patch, Hive-3938-Support_for_Multi-table-insert.patch > > > HiveMetaStore::add_partitions() currently adds all partitions specified in one call using a single meta-store transaction. This acts correctly. However, there's one AddPartitionEvent created per partition specified. > Ideally, the set of partitions added atomically can be communicated using a single AddPartitionEvent, such that they are consumed together. > I'll post a patch that does this. -- This message was sent by Atlassian JIRA (v6.1.5#6160)