Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03E31109D8 for ; Wed, 19 Feb 2014 03:13:57 +0000 (UTC) Received: (qmail 94347 invoked by uid 500); 19 Feb 2014 03:13:54 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 94280 invoked by uid 500); 19 Feb 2014 03:13:51 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 94267 invoked by uid 99); 19 Feb 2014 03:13:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Feb 2014 03:13:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 722021D4788; Wed, 19 Feb 2014 03:13:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6024164141209277981==" MIME-Version: 1.0 Subject: Re: Review Request 18250: SQL std auth - allow grant/revoke roles if user has ADMIN OPTION From: "Ashutosh Chauhan" To: "Navis Ryu" , "Ashutosh Chauhan" , "hive" Date: Wed, 19 Feb 2014 03:13:50 -0000 Message-ID: <20140219031350.29785.44356@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Chauhan" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/18250/ X-Sender: "Ashutosh Chauhan" References: <20140219020431.4367.30906@reviews.apache.org> In-Reply-To: <20140219020431.4367.30906@reviews.apache.org> Reply-To: "Ashutosh Chauhan" X-ReviewRequest-Repository: hive-git --===============6024164141209277981== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 19, 2014, 2:04 a.m., Navis Ryu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java, line 457 > > > > > > should this be doesUserHasGrantOption? Although our api says, role.isGrantOption(), sql syntax is "with admin option". So, I think doesUserHasAdminOption() makes sense. But, if you feel strongly about this, I can change it. Its a private method anyway, so doesn't matter that much. Let me know what you prefer. > On Feb. 19, 2014, 2:04 a.m., Navis Ryu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java, line 465 > > > > > > nit. indent will fix this. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18250/#review34828 ----------------------------------------------------------- On Feb. 19, 2014, 12:28 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18250/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 12:28 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6433 > https://issues.apache.org/jira/browse/HIVE-6433 > > > Repository: hive-git > > > Description > ------- > > SQL std auth - allow grant/revoke roles if user has ADMIN OPTION > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java c1afaee > ql/src/test/queries/clientpositive/authorization_role_grant2.q PRE-CREATION > ql/src/test/results/clientpositive/authorization_role_grant2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/18250/diff/ > > > Testing > ------- > > Added new test > > > Thanks, > > Ashutosh Chauhan > > --===============6024164141209277981==--