Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 501F010AAC for ; Wed, 5 Feb 2014 11:04:44 +0000 (UTC) Received: (qmail 20333 invoked by uid 500); 5 Feb 2014 11:04:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 20230 invoked by uid 500); 5 Feb 2014 11:04:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 20210 invoked by uid 99); 5 Feb 2014 11:04:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 11:04:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE1001C0486; Wed, 5 Feb 2014 11:04:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1745387368009813091==" MIME-Version: 1.0 Subject: Review Request 17737: Add DECIMAL support to vectorized group by operator From: "Remus Rusanu" To: "Jitendra Pandey" , "Eric Hanson" Cc: "Remus Rusanu" , "hive" Date: Wed, 05 Feb 2014 11:04:39 -0000 Message-ID: <20140205110439.26209.2134@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Remus Rusanu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17737/ X-Sender: "Remus Rusanu" Reply-To: "Remus Rusanu" X-ReviewRequest-Repository: hive-git --===============1745387368009813091== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17737/ ----------------------------------------------------------- Review request for hive, Eric Hanson and Jitendra Pandey. Bugs: HIVE-6344 https://issues.apache.org/jira/browse/HIVE-6344 Repository: hive-git Description ------- Implements Decimal aggregate operators, decimal vector hash key wrapper, extends vectorizer to support decimal in GBY. Diffs ----- ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 1b76fc9 common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 2e0f058 common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 29c5168 common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java fb3c346 common/src/java/org/apache/hive/common/util/Decimal128FastBuffer.java PRE-CREATION ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt PRE-CREATION ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVarDecimal.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java f083d86 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java e978110 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java f5ab731 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java f513188 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriter.java e5c3aa4 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java a242fef ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFSumDecimal.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java ad96fa5 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 1a00800 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java a2b45f8 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeVectorRowBatchFromObjectIterables.java c8eaea1 serde/src/test/org/apache/hadoop/hive/serde2/io/TestHiveDecimalWritable.java PRE-CREATION Diff: https://reviews.apache.org/r/17737/diff/ Testing ------- New unit tests added, manually tested decimal GBY queries Thanks, Remus Rusanu --===============1745387368009813091==--