Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 94DD7109E4 for ; Wed, 5 Feb 2014 00:10:56 +0000 (UTC) Received: (qmail 11429 invoked by uid 500); 5 Feb 2014 00:10:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 11371 invoked by uid 500); 5 Feb 2014 00:10:54 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 11359 invoked by uid 99); 5 Feb 2014 00:10:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 00:10:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46F3F1D4763; Wed, 5 Feb 2014 00:10:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0113674624439845671==" MIME-Version: 1.0 Subject: Re: Review Request 17718: Added special role PUBLIC. From: "Thejas Nair" To: "Thejas Nair" Cc: "Ashutosh Chauhan" , "hive" Date: Wed, 05 Feb 2014 00:10:53 -0000 Message-ID: <20140205001053.14639.15487@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/17718/ X-Sender: "Thejas Nair" References: <20140205000216.26209.60709@reviews.apache.org> In-Reply-To: <20140205000216.26209.60709@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============0113674624439845671== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17718/#review33665 ----------------------------------------------------------- Ship it! Ship It! - Thejas Nair On Feb. 5, 2014, 12:02 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17718/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 12:02 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-5960 > https://issues.apache.org/jira/browse/HIVE-5960 > > > Repository: hive-git > > > Description > ------- > > Added special role PUBLIC. > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 6fcdd29 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9ad5986 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 2d8e483 > ql/src/test/queries/clientnegative/authorization_public_create.q PRE-CREATION > ql/src/test/queries/clientnegative/authorization_public_drop.q PRE-CREATION > ql/src/test/queries/clientnegative/authorize_grant_public.q PRE-CREATION > ql/src/test/queries/clientnegative/authorize_revoke_public.q PRE-CREATION > ql/src/test/results/clientnegative/authorization_fail_7.q.out 7bfb6e6 > ql/src/test/results/clientnegative/authorization_public_create.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorization_public_drop.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorize_grant_public.q.out PRE-CREATION > ql/src/test/results/clientnegative/authorize_revoke_public.q.out PRE-CREATION > ql/src/test/results/clientpositive/authorization_1.q.out 3391bcd > ql/src/test/results/clientpositive/authorization_1_sql_std.q.out a0b1ce0 > ql/src/test/results/clientpositive/authorization_5.q.out 3aeaeca > ql/src/test/results/clientpositive/authorization_role_grant1.q.out 981060f > ql/src/test/results/clientpositive/authorization_view.q.out 23a1c0b > > Diff: https://reviews.apache.org/r/17718/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Ashutosh Chauhan > > --===============0113674624439845671==--