hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6356) Dependency injection in hbase storage handler is broken
Date Wed, 19 Feb 2014 00:35:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904874#comment-13904874
] 

Navis commented on HIVE-6356:
-----------------------------

bq. Even on 0.96.0, both mapred.TableMapReduceUtil#addDependencyJars(JobConf) and mapreduce.TableMapReduceUtil#addDependencyJars(Job)
handle the hbase dependencies for you

Really wish to call the method but all we got is JobConf, not Job and there is no way just
to wrap existing JobConf(copies in it) with Job. So in patch3, I've create dummy Job instance
to call it and copied values(in "tmpJars") in it to original JobConf. I've mentioned this
once already and even quoted again as you requested explanation. 

bq. o.a.h.hbase.mapreduce.TableMapReduceUtil takes Job as parameter rather than JobConf
bq. "..or make new Job instance and copy values from it to original JobConf". You can see
it in patch3.

I'm ok with fixing this in anyway (upgrade hbase to 0.96.1 or applying patch3), though I prefer
the later way to support hbase-0.96.0, which is still in use by many companies.

> Dependency injection in hbase storage handler is broken
> -------------------------------------------------------
>
>                 Key: HIVE-6356
>                 URL: https://issues.apache.org/jira/browse/HIVE-6356
>             Project: Hive
>          Issue Type: Bug
>          Components: HBase Handler
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: HIVE-6356.1.patch.txt, HIVE-6356.2.patch.txt, HIVE-6356.3.patch.txt,
HIVE-6356.addendum.00.patch
>
>
> Dependent jars for hbase is not added to tmpjars, which is caused by the change of method
signature(TableMapReduceUtil.addDependencyJars).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message