hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6356) Dependency injection in hbase storage handler is broken
Date Thu, 06 Feb 2014 01:52:08 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892899#comment-13892899
] 

Navis commented on HIVE-6356:
-----------------------------

Sadly, patch2 cannot resolve this issue. I should I have done some tests before updating the
patch (the problem looked so obvious, sorry). o.a.h.hbase.mapred.TableMapReduceUtil#addDependencyJars(JobConf)
is only works with older version of hbase.

Now back to the problem, o.a.h.hbase.mapreduce.TableMapReduceUtil takes Job as parameter rather
than JobConf, which seemed not good idea thinking that it's mere a wrapper of JobConf. Anyway,
we can resolve this with patch1 (copy needed class list from TableMapReduceUtil) or make new
Job instance and copy values from it to original JobConf. Which one is better?

> Dependency injection in hbase storage handler is broken
> -------------------------------------------------------
>
>                 Key: HIVE-6356
>                 URL: https://issues.apache.org/jira/browse/HIVE-6356
>             Project: Hive
>          Issue Type: Bug
>          Components: HBase Handler
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: HIVE-6356.1.patch.txt, HIVE-6356.2.patch.txt
>
>
> Dependent jars for hbase is not added to tmpjars, which is caused by the change of method
signature(TableMapReduceUtil.addDependencyJars).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message