hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6204) The result of show grant / show role should be tabular format
Date Tue, 04 Feb 2014 00:56:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890217#comment-13890217
] 

Thejas M Nair commented on HIVE-6204:
-------------------------------------

I think, ideally we should not have test specific conditions in the main code. One way to
workaround it would be to use another configurable class that returns the timestamp. In case
of tests, we use a class that just returns a hard-coded time. This would be something similar
to dependency injection. But this is probably something that can also be done in a separate
jira.

If hive had the ability to have metadata statements such as this in subquery, we could have
solved this by selecting the appropriate fields for testing.
Navis, can you please create a reviewboard link as well ?


> The result of show grant / show role should be tabular format
> -------------------------------------------------------------
>
>                 Key: HIVE-6204
>                 URL: https://issues.apache.org/jira/browse/HIVE-6204
>             Project: Hive
>          Issue Type: Improvement
>          Components: Authorization
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-6204.1.patch.txt
>
>
> {noformat}
> hive> show grant role role1 on all;
> OK
> database	default
> table	src
> principalName	role1
> principalType	ROLE
> privilege	Create
> grantTime	Wed Dec 18 14:17:56 KST 2013
> grantor	navis
> database	default
> table	srcpart
> principalName	role1
> principalType	ROLE
> privilege	Update
> grantTime	Wed Dec 18 14:18:28 KST 2013
> grantor	navis
> {noformat}
> This should be something like below, especially for JDBC clients.
> {noformat}
> hive> show grant role role1 on all;
> OK
> default	src			role1	ROLE	Create	false	1387343876000	navis
> default	srcpart			role1	ROLE	Update	false	1387343908000	navis
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message