hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yin Huai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6163) OrcOutputFormat#getRecordWriter creates OrcRecordWriter with relative path
Date Wed, 05 Feb 2014 12:56:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892067#comment-13892067
] 

Yin Huai commented on HIVE-6163:
--------------------------------

I think we should also check all other OutputFormats and make sure they all have the consistent
behaviors on creating file paths. 

> OrcOutputFormat#getRecordWriter creates OrcRecordWriter with relative path
> --------------------------------------------------------------------------
>
>                 Key: HIVE-6163
>                 URL: https://issues.apache.org/jira/browse/HIVE-6163
>             Project: Hive
>          Issue Type: Bug
>          Components: File Formats
>    Affects Versions: 0.12.0
>            Reporter: Branky Shao
>
> Hi,
> OrcOutputFormat#getRecordWriter creates OrcRecordWriter instance using a file with relative
path actually.
> return new OrcRecordWriter(new Path(name), OrcFile.writerOptions(conf));
> https://github.com/apache/hive/blob/7263b3bb1632b1a7c6ef5d2363e58020e1fdd756/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcOutputFormat.java#L114
> The fix should be very simple, just as RCFileOutputFormat#getRecordWriter, append work
output path as the parent:
> Path outputPath = getWorkOutputPath(job);
> Path file = new Path(outputPath, name);
> https://github.com/apache/hive/blob/d85eea2dc5decbf23e8f4010b32f1817cf057ea0/ql/src/java/org/apache/hadoop/hive/ql/io/RCFileOutputFormat.java#L78



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message