hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5953) SQL std auth - authorize grant/revoke on table
Date Sat, 08 Feb 2014 01:29:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895349#comment-13895349
] 

Lefty Leverenz commented on HIVE-5953:
--------------------------------------

Typos in patch 3, mostly trivial:

* lines 769 & 824:  "a authorization" should be "an authorization"
* line 959:  "the hive privilege" should be "Hive"
* package-info.java (lines 1037-1067):
**  "hive" should be "Hive" on lines 1038, 1040, 1041, 1049, 1059
**  "and" could be added before last class name on line 1042
**  unnecessary comma on line 1045 (but it does no harm)
**  "The methods in the interface throws two ..." should be "throw"
**  "one is the actions performed by the access control statements, which updates ... (and
stores ...), and also retrieves ..." on lines 1053-1055:  if updates, stores, & retrieves
go with "one" then this is okay, but if they go with "actions" or "statements" then drop the
final "s" on the verbs
**  "the privileges ... (and stores in some where like metastore database)" on lines 1054-1055:
 "somewhere" & "stores them"?
**  "and juse a no-op" on line 1056:  "use"
**  micronit:  "eg," technically should be "e.g.," but nobody really cares
**  unnecessary initial spaces on lines 1058 & 1062
**  "HiveAuthorizationValidator has interface" on line 1062:  "has the interface"
**  "HiveAuthorizerImpl is a convenience class that you can use by just passing the implementations
of these two interfaces (HiveAuthorizerImpl, HiveAuthorizationValidator) in the constructor"
on lines 1064-1065:  should the 2nd HiveAuthorizerImpl be HiveAccessController?

That's it for now; I'll go through the rest of the javadoc comments later.  Sorry for not
doing this in the review board.  (Can't register -- should I open an INFRA ticket or just
ask for help on dev@hive?)

> SQL std auth - authorize grant/revoke on table
> ----------------------------------------------
>
>                 Key: HIVE-5953
>                 URL: https://issues.apache.org/jira/browse/HIVE-5953
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Authorization
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>         Attachments: HIVE-5953.1.patch, HIVE-5953.2.patch, HIVE-5953.3.patch, HIVE-5953.4.patch
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> User (or a role user belongs to ) should have grant privileges to be able to grant/revoke
privileges for a user/role.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message