hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <leftylever...@gmail.com>
Subject Re: Review Request 18459: FS based stats.
Date Thu, 27 Feb 2014 01:02:20 GMT


> On Feb. 26, 2014, 4:55 p.m., Ashutosh Chauhan wrote:
> > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 626
> > <https://reviews.apache.org/r/18459/diff/1/?file=503283#file503283line626>
> >
> >     Didn't update template file, since as Lefty pointed out, soon it won't be required
anymore.
> >     Updating test hive-site may result in failures in existing test cases which
are written for jdbc stats collection (like hashing key etc). Each of those tests need to
be examined, then updated etc and given the rate at which patch queue is moving, that will
delay this patch endlessly.

The best place to document hive.stats.dbclass is in a release note for HIVE-6500.


- Lefty


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18459/#review35533
-----------------------------------------------------------


On Feb. 26, 2014, 4:37 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18459/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 4:37 p.m.)
> 
> 
> Review request for hive and Navis Ryu.
> 
> 
> Bugs: HIVE-6500
>     https://issues.apache.org/jira/browse/HIVE-6500
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> FS based stats collection.
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 1572127 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java 1572127

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java 1572127

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java 1572127

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsCollectionTaskIndependent.java
PRE-CREATION 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 1572127 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java PRE-CREATION

>   trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java PRE-CREATION

>   trunk/ql/src/test/queries/clientpositive/statsfs.q PRE-CREATION 
>   trunk/ql/src/test/results/clientpositive/statsfs.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18459/diff/
> 
> 
> Testing
> -------
> 
> Added new tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message