hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 18377: HIVE-6481. Add .reviewboardrc file
Date Fri, 21 Feb 2014 22:39:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18377/#review35201
-----------------------------------------------------------


Looks good. Minor question: do we need to put Apache license header for this new file?

- Xuefu Zhang


On Feb. 21, 2014, 9:36 p.m., Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18377/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 9:36 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-6481
>     https://issues.apache.org/jira/browse/HIVE-6481
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-6481. Add .reviewboardrc file
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18377/diff/
> 
> 
> Testing
> -------
> 
> I was able to post this review request with the command "rbt post" after committing my
changes locally.
> 
> 
> Thanks,
> 
> Carl Steinbach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message