hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 18200: HIVE-860 - Persistent distributed cache
Date Thu, 20 Feb 2014 20:13:29 GMT


> On Feb. 20, 2014, 8:06 p.m., Xuefu Zhang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java, line 44
> > <https://reviews.apache.org/r/18200/diff/8/?file=498177#file498177line44>
> >
> >     It appears that this class has no state, so there is no need to instantiate
it to gain any functionality from it. Maybe we can just keep everything static.

There is very little cost to creating a new object and once an item is static mocking is very
difficult. I'd prefer we keep it non-static.


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18200/#review35042
-----------------------------------------------------------


On Feb. 19, 2014, 8:35 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18200/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 8:35 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-860
>     https://issues.apache.org/jira/browse/HIVE-860
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Caches auxiliary jars and remote runtime jars in /user/$user/.hiveJars by their sha1
hash. This results in:
> 
> 1) faster queries
> 2) less distributed cache churn
> 3) a smaller/cleaner hive-exec jar
> 
> 
> Diffs
> -----
> 
>   bin/hive 3bd949f 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 
>   conf/hive-default.xml.template 0d08aa2 
>   packaging/src/main/assembly/bin.xml a97ef7d 
>   ql/pom.xml 53d0b9e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HiveAuxClasspathBuilder.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 326654f 
>   shims/aggregator/pom.xml 7aa8c4c 
> 
> Diff: https://reviews.apache.org/r/18200/diff/
> 
> 
> Testing
> -------
> 
> Tested manually on a cluster.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message