hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 18200: HIVE-860 - Persistent distributed cache
Date Thu, 20 Feb 2014 20:06:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18200/#review35042
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java
<https://reviews.apache.org/r/18200/#comment65422>

    It appears that this class has no state, so there is no need to instantiate it to gain
any functionality from it. Maybe we can just keep everything static.



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java
<https://reviews.apache.org/r/18200/#comment65438>

    For my info, does hadoop knows that a file is already in distributed cache so as to skip
it. Otherise, it will cache everytime a job is launched. I couldn't find doc about this.



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java
<https://reviews.apache.org/r/18200/#comment65408>

    Don't we need to close the stream from the open() call?



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java
<https://reviews.apache.org/r/18200/#comment65426>

    I'm not sure if we need put this in a synchronized block.



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java
<https://reviews.apache.org/r/18200/#comment65415>

    2. So the cached file is named without including its originial name? This might make it
hard to figure out if problem arises.


- Xuefu Zhang


On Feb. 19, 2014, 8:35 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18200/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 8:35 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-860
>     https://issues.apache.org/jira/browse/HIVE-860
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Caches auxiliary jars and remote runtime jars in /user/$user/.hiveJars by their sha1
hash. This results in:
> 
> 1) faster queries
> 2) less distributed cache churn
> 3) a smaller/cleaner hive-exec jar
> 
> 
> Diffs
> -----
> 
>   bin/hive 3bd949f 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 
>   conf/hive-default.xml.template 0d08aa2 
>   packaging/src/main/assembly/bin.xml a97ef7d 
>   ql/pom.xml 53d0b9e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HiveAuxClasspathBuilder.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 288da8e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/JarCache.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 326654f 
>   shims/aggregator/pom.xml 7aa8c4c 
> 
> Diff: https://reviews.apache.org/r/18200/diff/
> 
> 
> Testing
> -------
> 
> Tested manually on a cluster.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message