hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 18291: Add support for pluggable authentication modules (PAM) in Hive
Date Thu, 20 Feb 2014 00:36:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18291/#review34955
-----------------------------------------------------------



service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java
<https://reviews.apache.org/r/18291/#comment65353>

    Will this be better?
    1. Create a no-arg constructor.
    2. Manage all hiveconf stuffs in constructor and initialize only "pamServices" (a class
variable).
    3. It will reduce the overhead for consecutive  Authenticat(..) call
    4. These are similar to LDAPAuth...Impl.java
    


- Mohammad Islam


On Feb. 19, 2014, 11:44 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18291/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 11:44 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-6466
>     https://issues.apache.org/jira/browse/HIVE-6466
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Refer the jira: https://issues.apache.org/jira/browse/HIVE-6466
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 
>   pom.xml 9aef665 
>   service/pom.xml b1002e2 
>   service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java b92fd83

>   service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/18291/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message