hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 18250: SQL std auth - allow grant/revoke roles if user has ADMIN OPTION
Date Wed, 19 Feb 2014 21:51:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18250/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 9:51 p.m.)


Review request for hive.


Changes
-------

Incorporated Thejas feedback. Also, added new -ve test.


Bugs: HIVE-6433
    https://issues.apache.org/jira/browse/HIVE-6433


Repository: hive-git


Description
-------

SQL std auth - allow grant/revoke roles if user has ADMIN OPTION


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
c1afaee 
  ql/src/test/queries/clientnegative/authorization_role_grant.q PRE-CREATION 
  ql/src/test/queries/clientpositive/authorization_role_grant2.q PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_role_grant.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/authorization_set_role_neg2.q.out eec684d 
  ql/src/test/results/clientpositive/authorization_role_grant2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/18250/diff/


Testing
-------

Added new test


Thanks,

Ashutosh Chauhan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message