hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 18254: HIVE-6375 Implement CTAS and column rename for parquet
Date Wed, 19 Feb 2014 17:59:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18254/#review34879
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18254/#comment65260>

    This line seems to be a dupe of line 5665.


- Xuefu Zhang


On Feb. 19, 2014, 12:42 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18254/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:42 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6375
>     https://issues.apache.org/jira/browse/HIVE-6375
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> There is a Hive bug in SemanticAnalyzer that chooses different names for columns in the
CreateTable task and the FileSink task.  columnInfo.getInternalName() was used in one place,
and fieldSchema still used columnInfo.getAlias() if it is available.  This change makes both
consistent, favoring columnInfo.getAlias if it is available.
> 
> This is not revealed before because other file-formats like RcFile seem to use column-ordinal
position, and Avro file stores the schema separately altogether.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd 
>   ql/src/test/queries/clientpositive/parquet_ctas.q PRE-CREATION 
>   ql/src/test/results/clientpositive/ctas.q.out 9668855 
>   ql/src/test/results/clientpositive/parquet_ctas.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18254/diff/
> 
> 
> Testing
> -------
> 
> Added parquet_ctas.q.  Covers cases where column name is gotten directly from input table
(implied alias), where name is auto-generated, where name is specified as alias, and a mix
of the three.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message