hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 18250: SQL std auth - allow grant/revoke roles if user has ADMIN OPTION
Date Wed, 19 Feb 2014 16:31:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18250/#review34869
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/18250/#comment65253>

    We need to pass the roleNames argument to this function and check that user has admin
option on these roles. For example the role in grant-role could be role A while current role
is role B. The check is happening now on role B only.
    What should we do if a user a member with admin option of role Y , because it belongs
to role X and role X has admin option on Y?
    Should we check that X is in the current role in that case? I guess so, that will make
it consistent with rest of the current role behavior.



ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
<https://reviews.apache.org/r/18250/#comment65252>

    ADMIN_ONLY_MSG is not the right message with this change. For the grant/revoke roles statements,
we should change it to : ADMIN_ONLY_MSG + HAS_ADMIN_PRIV_MSG


- Thejas Nair


On Feb. 19, 2014, 3:31 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18250/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 3:31 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6433
>     https://issues.apache.org/jira/browse/HIVE-6433
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> SQL std auth - allow grant/revoke roles if user has ADMIN OPTION
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
c1afaee 
>   ql/src/test/queries/clientpositive/authorization_role_grant2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/authorization_role_grant2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18250/diff/
> 
> 
> Testing
> -------
> 
> Added new test
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message