hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 18250: SQL std auth - allow grant/revoke roles if user has ADMIN OPTION
Date Wed, 19 Feb 2014 03:13:50 GMT


> On Feb. 19, 2014, 2:04 a.m., Navis Ryu wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java,
line 457
> > <https://reviews.apache.org/r/18250/diff/1/?file=497250#file497250line457>
> >
> >     should this be doesUserHasGrantOption?

Although our api says, role.isGrantOption(), sql syntax is "with admin option". So, I think
doesUserHasAdminOption() makes sense. But, if you feel strongly about this, I can change it.
Its a private method anyway, so doesn't matter that much. Let me know what you prefer.


> On Feb. 19, 2014, 2:04 a.m., Navis Ryu wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java,
line 465
> > <https://reviews.apache.org/r/18250/diff/1/?file=497250#file497250line465>
> >
> >     nit. indent

will fix this.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18250/#review34828
-----------------------------------------------------------


On Feb. 19, 2014, 12:28 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18250/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 12:28 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6433
>     https://issues.apache.org/jira/browse/HIVE-6433
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> SQL std auth - allow grant/revoke roles if user has ADMIN OPTION
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java
c1afaee 
>   ql/src/test/queries/clientpositive/authorization_role_grant2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/authorization_role_grant2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18250/diff/
> 
> 
> Testing
> -------
> 
> Added new test
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message