hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani" <rhbut...@gmail.com>
Subject Re: Review Request 18172: HIVE-6439 Introduce CBO step in Semantic Analyzer
Date Mon, 17 Feb 2014 06:49:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18172/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 6:49 a.m.)


Review request for hive.


Changes
-------

John,
I agree with Gunther's points, I propose:
- we take out the max joins parameter from HiveConf for now; at least until it becomes clearer
that this is one of the ways we want to control CBO use.
- we move CostBasedOptimizer to the ql.optimizer package.

Do you agree?


Bugs: HIVE-6439
    https://issues.apache.org/jira/browse/HIVE-6439


Repository: hive-git


Description
-------

This patch introduces CBO step in SemanticAnalyzer. For now the CostBasedOptimizer is an empty
shell. 
The contract between SemAly and CBO is:
CBO step is controlled by the 'hive.enable.cbo.flag'.
When true Hive SemAly will hand CBO a Hive Operator tree (with operators annotated with stats).
If it can CBO will return a better plan in Hive AST form.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 
  conf/hive-default.xml.template 0d08aa2 
  ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java 1ba5654 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/PreCBOOptimizer.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/CostBasedOptimizer.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 52c39c0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd 

Diff: https://reviews.apache.org/r/18172/diff/


Testing
-------


Thanks,

Harish Butani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message