hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 18172: HIVE-6439 Introduce CBO step in Semantic Analyzer
Date Sun, 16 Feb 2014 21:18:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18172/#review34599
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java
<https://reviews.apache.org/r/18172/#comment64759>

    indentation needs fixing (2 spaces)



ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java
<https://reviews.apache.org/r/18172/#comment64758>

    The coding conventions followed by hive require braces with if statements.
    
    As hive follows Sun/Java code conventions (except for indentation of 2 chars, and line
limit of 100 chars), you can select the java code convention under eclipse formatter and select
the java profile, edit it for these two settings and save it as hive profile.
    
    Then highlight your section of new/edited code, right-click source->format .
    I will add these instructions to HowToContribute once the wiki is working again.
    



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18172/#comment64760>

    indentation issues



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/18172/#comment64761>

    braces needed for if
    


- Thejas Nair


On Feb. 16, 2014, 8:39 p.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18172/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 8:39 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-6439
>     https://issues.apache.org/jira/browse/HIVE-6439
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch introduces CBO step in SemanticAnalyzer. For now the CostBasedOptimizer is
an empty shell. 
> The contract between SemAly and CBO is:
> CBO step is controlled by the 'hive.enable.cbo.flag'.
> When true Hive SemAly will hand CBO a Hive Operator tree (with operators annotated with
stats). If it can CBO will return a better plan in Hive AST form.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 
>   conf/hive-default.xml.template 0d08aa2 
>   ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java 1ba5654 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/PreCBOOptimizer.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/CostBasedOptimizer.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 52c39c0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd 
> 
> Diff: https://reviews.apache.org/r/18172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harish Butani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message